Skip to content

fix(release): tag with a git identity, release:prepare waits for pending releases - #298

Merged
pviti merged 1 commit into
mainfrom
fix/release-prepare
Oct 15, 2026
Merged

pviti merged 1 commit into
mainfrom
fix/release-prepare

Conversation

@pviti

@pviti pviti commented Oct 15, 2026

Copy link
Copy Markdown
Member

Release: git identity for the tags, release:prepare, no double releases

The release of cli 7.1.0 (#296) showed three problems.

1. Publish failed on git tag

The release tags are annotated, and the GitHub runner has no git identity: Committer identity unknown. The previous tags had been created by hand, so this was the first tag Publish created itself. Nothing was published: the job stopped before npm.

Fix: publish.yml sets the identity of github-actions[bot] before cl-release ship.

2. pnpm release:publish → pnpm release:prepare

The script prepares a release (version bump + release PR). The name suggested it publishes, and it was run after the merge, while Publish does that. Docs, comments and messages are updated.

3. A second release PR for the same changes (#297, closed)

release:prepare was run right after the merge of #296, while 7.1.0 was not tagged yet. It compared with cli-v7.0.0 and proposed the same changes as 7.2.0.

Fix: release:prepare stops while a public package version is not on npm yet:

✖ Not released yet: @commercelayer/cli@7.1.0. Wait for publish.yml to publish them (Actions → Publish; run it again if it failed), then prepare the next release.

I checked this on an up-to-date main with the tooling of this branch, and that is the message it printed.

⚠️ On merge

Publish runs on the merge commit and publishes cli 7.1.0: the tag cli-v7.1.0, npm, the GitHub release and Slack. The tooling comes from the merge commit, so it includes the git identity.

Checks

Release package: type-check passes, 26 tests pass. pnpm lint and check-packages pass.

🤖 Generated with Claude Code

…ing releases

- publish.yml sets the git identity of github-actions[bot] before ship: the
  release tags are annotated, and the runner has no identity (the 7.1.0 run
  failed on `git tag`; the earlier tags were made by hand)
- the release PR script is now `pnpm release:prepare`: it prepares a
  release, publish.yml publishes it on merge
- release:prepare stops while a merged release is not on npm yet: its tags
  don't exist yet, so it proposed the same changes again (cli 7.2.0, #297)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pviti
pviti merged commit 2606691 into main Oct 15, 2026
10 checks passed
@pviti
pviti deleted the fix/release-prepare branch October 15, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants