Repository navigation
fix(release): tag with a git identity, release:prepare waits for pending releases - #298
Merged
Merged
Conversation
…ing releases - publish.yml sets the git identity of github-actions[bot] before ship: the release tags are annotated, and the runner has no identity (the 7.1.0 run failed on `git tag`; the earlier tags were made by hand) - the release PR script is now `pnpm release:prepare`: it prepares a release, publish.yml publishes it on merge - release:prepare stops while a merged release is not on npm yet: its tags don't exist yet, so it proposed the same changes again (cli 7.2.0, #297) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pviti
requested review from
cl-mvezzelli,
gciotola,
malessani,
marco-commercelayer and
pfferrari
October 15, 2026 14:47
marco-commercelayer
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release: git identity for the tags,
release:prepare, no double releasesThe release of cli 7.1.0 (#296) showed three problems.
1. Publish failed on
git tagThe release tags are annotated, and the GitHub runner has no git identity:
Committer identity unknown. The previous tags had been created by hand, so this was the first tag Publish created itself. Nothing was published: the job stopped before npm.Fix:
publish.ymlsets the identity ofgithub-actions[bot]beforecl-release ship.2.
pnpm release:publish→pnpm release:prepareThe script prepares a release (version bump + release PR). The name suggested it publishes, and it was run after the merge, while Publish does that. Docs, comments and messages are updated.
3. A second release PR for the same changes (#297, closed)
release:preparewas run right after the merge of #296, while 7.1.0 was not tagged yet. It compared withcli-v7.0.0and proposed the same changes as 7.2.0.Fix:
release:preparestops while a public package version is not on npm yet:I checked this on an up-to-date
mainwith the tooling of this branch, and that is the message it printed.Publish runs on the merge commit and publishes cli 7.1.0: the tag
cli-v7.1.0, npm, the GitHub release and Slack. The tooling comes from the merge commit, so it includes the git identity.Checks
Release package: type-check passes, 26 tests pass.
pnpm lintandcheck-packagespass.🤖 Generated with Claude Code